Update GTest CMake for use w/ sanitizers#210
Merged
Conversation
Ensure that GoogleTest is fetched and built from source with the same flags as the library when building with the sanitizers enabled. Without this, we don't see useful output when there are failures.
derobins
requested review from
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon and
zbyrne
as code owners
Collaborator
Author
|
@copilot please review |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CMake GoogleTest integration so sanitizer builds always compile GoogleTest from source with matching flags, improving sanitizer diagnostics and failure output.
Changes:
- Conditionally disables system
find_package(GTest)fallback whenAIS_USE_SANITIZERSis enabled. - Standardizes cache option descriptions and status messages for “GoogleTest”.
- Fixes the “fetched vs system” detection to key off
googletest_SOURCE_DIR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jordan-turbofish
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that GoogleTest is fetched and built from source with the same flags as the library when building with the sanitizers enabled. Without this, we don't see useful output when there are failures.
Part of AIHIPFILE-62